Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a nil result #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ryanfaerman
Copy link

This prevents throwing our stack just because the result is nil.

This prevents throwing our stack just because the `result` is `nil`.
@@ -54,6 +54,7 @@ def self.execute(verbose, options)
# notify_result('@timeout', {'reply' => true}) #=> '@timeout'
# notify_result('I may like pie', {}) #=> :i_may_like_pie
def notify_result(result, options, always_string = false)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about giving a default value to result instead?

@y-yagi
Copy link

y-yagi commented May 14, 2018

@ryanfaerman Are you still interested in this PR? I encountered this issue too, and want to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants