Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-48106 #2965

Closed
wants to merge 13 commits into from
Closed

LPS-48106 #2965

wants to merge 13 commits into from

Conversation

jorgediaz-lr
Copy link

It depends on pull #2964 so do not merge it until the other pull is commited

jorgediaz-lr and others added 13 commits July 7, 2014 15:54
@jorgediaz-lr
LPS-46764 New reindex and doReindex functions with propagate paramete…
58d26ed 
…r to allow diferent logic in each case
@jorgediaz-lr
LPS-46764 Add propagate param to Indexable annotation
8f58227
@jorgediaz-lr
LPS-46764 New function fetchPreviousIndexableArticle
ec8a457
@jorgediaz-lr
LPS-46764 At doReindex, if propagate=false we avoid index all versions
7c1ab20
@ealonso @jorgediaz-lr
LPS-46764 SF
fa09f0f
@jorgediaz-lr
LPS-46764 SF
89b06f0
@jorgediaz-lr
LPS-46764 Do not index all versions at addArticle, updateArticle and …
f48ff6b 
…updateContent
@jorgediaz-lr
LPS-46764 Do not index all versions, unless categories, tags or urlti…
14a0523 
…tle are modified
@jorgediaz-lr
LPS-46764 Avoid index at local invocations of updateStatus
6cb4337
@jorgediaz-lr
LPS-46764 Change updateStatus to protected
168d593
@jorgediaz-lr
LPS-46764 Autogenerated
be69f15
@jorgediaz-lr
LPS-48106 Do not index all versions, unless is moved to other folder …
6e3c379 
…or to recycle bin
@jorgediaz-lr
LPS-48106 By default, we set propagate to false as default behaviour
d9815f0
@liferay-dev-ci
Copy link
Collaborator

Some tests have FAILED. ❌
Please use the following link to check if any of them are related to your changes.
Refer to this link for build results: http://ci.liferay.org.es/jenkins/job/juliocamarero/2132/

@jorgediaz-lr
Copy link
Author

Finally, the following approach will be followed:

  • Journal Reindex main problems will be fixed only at master, see LPS-48106
  • For 6.2.x, we will only reindex last published version, see LPS-48407

Some minor changes at LPS-46764 were ok and have been commited to master, so they will be backported to 6.2.x:

  • Avoid some redundant indexations
  • Don't change the url title unless necessary
  • Rewrite of doDelete logic, to avoid index all versions at delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgediaz-lr @liferay-dev-ci @ealonso