Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SQLAlchemy 1.4 #69

Merged
merged 4 commits into from Apr 13, 2023
Merged

Support for SQLAlchemy 1.4 #69

merged 4 commits into from Apr 13, 2023

Conversation

bodik
Copy link
Contributor

@bodik bodik commented Jul 2, 2021

Based on #64 and #68 I've elaborated on Sqlalchemy 1.4 backward compatible support

Copy link

@munkien munkien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my test environment!

@pcasa
Copy link

pcasa commented Sep 22, 2021

Is there anything blocking this PR? Would love to upgrade Sqlalchemy.

@kinlamleung
Copy link

kinlamleung commented Oct 8, 2021

This package hasn't been updated for a long time, we have projects with this tool and planned to upgrade sqlalchemy to 1.4.

Any plan to release a new version? We may need to drop out this dependency if no plan on the support SA 1.4. Thanks.

@pcasa
Copy link

pcasa commented Oct 28, 2021

This package hasn't been updated for a long time, we have projects with this tool and planned to upgrade sqlalchemy to 1.4.

Any plan to release a new version? We may need to drop out this dependency if no plan on the support SA 1.4. Thanks.

We are on the same situation.

@bodik
Copy link
Contributor Author

bodik commented Oct 30, 2021

either we can try to reach @juliotrigo via some other means that github and ask for maitainers permissions or fork the project under new name ;/

@bodik
Copy link
Contributor Author

bodik commented Nov 15, 2021

FYI #72

@LyleScott
Copy link

This is open source, you just fork and move on IMHO. No need for permission.

@bodik
Copy link
Contributor Author

bodik commented Nov 16, 2021

This is open source, you just fork and move on IMHO. No need for permission.

but with permission we might be able to continue under same package name on pypi

@mvilanova
Copy link

Has anyone tried this alternative https://github.com/elmkarami/sqlalchemy-filters-plus, which has support for SQLAlchemy 1.4?

@hereischen
Copy link

Has anyone tried this alternative https://github.com/elmkarami/sqlalchemy-filters-plus, which has support for SQLAlchemy 1.4?

This one works

@tomviner tomviner merged commit 8c469e5 into juliotrigo:master Apr 13, 2023
@bodik bodik deleted the fix-sqla14 branch November 3, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants