Support SqlAlchemy 1.4 and Python 3.9 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tatables usecase)
and add sqlalchemy 1.4
heindsight
reviewed
Apr 11, 2023
setup.py
Outdated
Comment on lines
28
to
29
| # for sqlalchemy1.4 >= 0.37 is required | ||
| 'sqlalchemy-utils>=0.36.3', |
There was a problem hiding this comment.
That was intended. py27 wasn't compatible with 0.36.3, so that customisation was done in tox.ini. Anyway, I've removed py27 support now.
sqlalchemy_filters/models.py
Outdated
| models.extend(mapper.class_ for mapper in query._join_entities) | ||
|
|
||
| # account joined entities | ||
| if sqlalchemy_version_lt('1.4'): # pragma: nocover |
There was a problem hiding this comment.
It might be worth using this https://github.com/wemake-services/coverage-conditional-plugin instead of just pragma: nocover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the good work in #69 and expands Github Actions for new versions.
Changes:
pragma: nocoverlabels, this is because any one test run with particular versions isn't comprehensive, but overall, all branches are coveredFurther changes after review:
coverage-conditional-plugin(requires Python>3.7) to ensure we have overall 100% coveragepython_requires='>=3.7'which means this release is still backwards compatible, as old Pythons can't install it by mistake