Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual Roller Shutter / Expose single curtain positions to HA #23

Closed
madzrobz opened this issue May 13, 2019 · 6 comments · Fixed by #350
Closed

Dual Roller Shutter / Expose single curtain positions to HA #23

madzrobz opened this issue May 13, 2019 · 6 comments · Fixed by #350

Comments

@madzrobz
Copy link
Contributor

The "Dual Roller Shutter" has two curtains which can be controlled separately by sending FP1 or FP2 instead of MP in GW_COMMAND_SEND_REQ.

MP: Position of the two curtains
FP1: Position of the upper curtain
FP2: Position of the lower curtain

Could this somehow be exposed to homeassistant?

Options I see:

  1. create two covers for each "Dual Roller Shutter"
  2. add an additional parameter (e.g. curtain=both(default)/upper/lower) to cover.set_cover_position
  3. ...?

By looking at the code, I believe it should not be too complex - but unfortunately I'm a complete newbie to python and currently lacking time to learn so I'm unable to do it myself.

Thank you!

@madzrobz madzrobz changed the title Dual Roller Shutter / Expose single curtain positions Dual Roller Shutter / Expose single curtain positions to HA May 13, 2019
@Julius2342
Copy link
Owner

Julius2342 commented May 13, 2019

Wouldn't this be three shutters then? (top, bottom and combined). And you could ignore the ones you want.

I think we should integrate this in one pyvlx device and make it accessible via functions - on hass side we can then generate three HASS cover-devices, containing a reference to the (same) pyvlx object.

@madzrobz
Copy link
Contributor Author

madzrobz commented May 13, 2019

You are right, to make it consistent and allow the current position to be properly managed by HA, it must be 3 covers.

@Arduous
Copy link
Contributor

Arduous commented Jun 23, 2019

The idea of exposing 3 distinct shutters seems to be the best trade-off in terms of functionality and complexity.

@Julius2342
Copy link
Owner

In a first step we should add functionality to CommandSend to either address "main parameter" or "functional parameter". If this works out on a low level we could can decide how to implement this on devices - and as a last step how to create devices automatically.

@Julius2342
Copy link
Owner

For anyone who jumps in: the magic is here: https://github.com/Julius2342/pyvlx/blob/master/pyvlx/frames/frame_command_send.py#L31 ... :-)

@madzrobz
Copy link
Contributor Author

madzrobz commented May 7, 2021

Pull request for addressing the single curtains created.
#66

The question remains, how to integrate with home assistant.

I still believe that simply adding a "curtain" parameter to the cover.set_position function would be sufficient and simpler then exposing three covers to home assistant (as discussed in 2019).

I did not explore whether/how KLF 200 reports position changes on the sub-covers. I'm not sure whether we would be able to maintain the correct position of these sub-covers in home assistant. Thus only providing a one-way function call to set the position of the sub-curtains seems to be perfectly fine for me.

@pawlizio pawlizio linked a pull request Nov 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants