-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise maxLength limit #26
Comments
Hi, this is something that has been previously discussed and it seems like the 3000 character limit still holds. Here is the previous answer: comment |
Have you successfully tried the package with messages longer than 3000 character? I think it might be possible to have longer messages in case the section block is not used. |
Yes I have experimented with very long messages and more character can get through, but not anywhere near 40000. I have a feeling the limit is based on displayed characters not actual characters, e.g. for a link that displays text is shorter than the full label and URL markup. Just a theory but increasing the max limit definitely allowed more characters through in my testing. |
AFAIK the limit for a message is 40000 characters. However, there is a much stricter limit to consider. When using a We are considering to allow a much larger character length when the user inputs a template, but if they use a |
Hnmm I am on holiday this week, so I cannot check. But, I was using an attachment text field with more than 3000 characters, and saw more characters on slack with a higher max limit. |
The original limit is explicitly based on I do also agree that there should be a way to change the limits, but it should be very clear that it is an unsafe action, and having good defaults should be a priority. Do you think it would be more clear that we do not recommend to change the config if it is called something like |
I was trying to find some-sort of schema, but slack does not seem to provide anything outside of some TypeScript types (which don't include property length). Also their own node webhook API does not do any sanitisation. I guess there are a few options:
|
This problem is more complicated than I first thought 😅 Thanks for the extensive explanation! I think option 3 is the nicest, but it might not be feasible. I would suggest doing option 1 one until a better solution comes. It will give the control and responsibility to the users of the plugin. |
* feat: add maxLength option * refactor: prefix max length option with unsafe * docs(readme): update max length option with unsafe * docs(readme): revert indent fixes: #26
🎉 This issue has been resolved in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I believe the
maxLength
limit here: https://github.com/juliuscc/semantic-release-slack-bot/blob/master/lib/success.js#L9 is outdated the docs seem to indicate that messages will be truncated on Slack's end at 40,000 characters.Perhaps
maxLength
should be a config option and defaulted to 3000 as to not break things going forward, but allows a user to increase it as they please. Or maybe set it to 40,000 and bump the major version?The text was updated successfully, but these errors were encountered: