Merge pull request #24 from dimhotepus/fix-incorrect-overflow-check

rtcp: Fix check for LengthInWordsMinusOne out of bounds
juliusfriedman · Oct 25, 2023 · 10ccf4f · 10ccf4f
2 parents 466cd90 + 856ed54
commit 10ccf4f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/Rtp/Rtcp/RtcpHeader.cs b/Rtp/Rtcp/RtcpHeader.cs
@@ -225,7 +225,7 @@ public int LengthInWordsMinusOne
                 /*CheckDisposed();*/
 
                 //Write the value
-                if (value > RtcpHeader.MinimumLengthInWords) throw Binary.CreateOverflowException("LengthInWordsMinusOne", value, ushort.MinValue.ToString(), ushort.MaxValue.ToString());
+                if (value < RtcpHeader.MinimumLengthInWords || value > RtcpHeader.MaximumLengthInWords) throw Binary.CreateOverflowException("LengthInWordsMinusOne", value, RtcpHeader.MinimumLengthInWords.ToString(), RtcpHeader.MaximumLengthInWords.ToString());
 
                 Binary.Write16(SegmentToLast6Bytes.Array, SegmentToLast6Bytes.Offset, Common.Binary.IsLittleEndian, (ushort)value);
             }