Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtcp: Fix check for LengthInWordsMinusOne out of bounds #24

Merged
merged 1 commit into from
Oct 25, 2023
Merged

rtcp: Fix check for LengthInWordsMinusOne out of bounds #24

merged 1 commit into from
Oct 25, 2023

Conversation

dimhotepus
Copy link
Contributor

@dimhotepus dimhotepus commented Oct 25, 2023 •
edited

Was broken as we started to throw OverflowException.

@dimhotepus dimhotepus mentioned this pull request Oct 25, 2023
Closed
juliusfriedman
juliusfriedman approved these changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@juliusfriedman juliusfriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will accept these changes, are all tests passing still?

@juliusfriedman juliusfriedman merged commit 10ccf4f into juliusfriedman:master Oct 25, 2023
3 checks passed
@dimhotepus dimhotepus deleted the fix-incorrect-overflow-check branch October 25, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusfriedman juliusfriedman juliusfriedman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimhotepus @juliusfriedman