Fix writing fractional seconds#49
Merged
julman99 merged 2 commits intoNov 2, 2020
Merged
Conversation
added 2 commits
October 2, 2020 15:53
Fractional seconds with leading zeros are parsed correctly but written incorrectly, eg ".066" -> ".66" This include a change to also allow the user to choose if they always want to see 3 digits in the fractional part or not, eg ".730" vs ".73" basically removing trailing zeros
julman99
approved these changes
Nov 2, 2020
Owner
|
Nice catch! Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fractional seconds with leading zeros are parsed correctly but written back incorrectly, eg ".073" -> ".73"
This test fails in master branch:
with
Also included is a change to allow the user to choose if they always want to see 3 digits in the fractional seconds part or not, eg ".730" vs ".73", basically by not removing trailing zeros. The default is set to remove trailing zeros, thus keeping the original writing behaviour.