Added userInfo response type check to handle signed and encrypted res… #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeepDiver1975 do we want to use an interface or should we use a callback like in pr #322? |
|
My personal answer would be: Alternative would be to use a callback just like done in any other place - just to make sure we are not mixing too much concepts. |
ricklambrechts
force-pushed
the
handle-application-jwt
branch
from
ec92e27
to
f3196f3
Compare
# Conflicts: # CHANGELOG.md # src/OpenIDConnectClient.php
…jwe functionality
|
@DeepDiver1975 thanks. I updated the code |
|
@DeepDiver1975 Any chance of getting this merged in? |
|
@DeepDiver1975 this would be very helpful for us as well. |
DeepDiver1975
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add support for signed and/or encrypted UserInfo response.
https://openid.net/specs/openid-connect-core-1_0.html#rfc.section.5.3.2
Added response contentType field to hold value of the latest content type
Added jweResponseHandler so the package user can set an handler to decrypt the JWE
Handle signed jwt response from user info endpoint
Added support for encrypted id_token.
According to the docs, it is possible that the id token is encrypted. I added additional code that will decrypt the id_token when it is an JWE.
List of common tasks a pull request require complete