Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LogoutToken verification for single value aud claims #334

Merged

Conversation

osnard
Copy link

@osnard osnard commented Sep 30, 2022

... and add UnitTests for verifyLogoutTokenClaims.

See #333

List of common tasks a pull request require complete

  • Changelog entry is added or the pull request don't alter library's functionality

Copy link
Collaborator

@azmeuk azmeuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arifulbd
Copy link

Could you please resolve this soon, LogoutToken verification is broken due to this.
@azmeuk @DeepDiver1975

@azmeuk
Copy link
Collaborator

azmeuk commented Mar 29, 2023

@osnard can you please fix the CHANGELOG conflicts so we can merge this patch? 🙏

@osnard
Copy link
Author

osnard commented Mar 29, 2023

Done

@azmeuk azmeuk merged commit e46f108 into jumbojett:master Mar 29, 2023
@osnard osnard deleted the Fix_LogoutToken_Validation_AUD_Claim branch June 19, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants