Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up signatures #415

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix up signatures #415

wants to merge 3 commits into from

Conversation

hexmode
Copy link

@hexmode hexmode commented Apr 20, 2024

Also add phpunit dependency, add test target, fix up phpunit.xml.dist, and add changelog entry.

Fixes #412

@osnard
Copy link

osnard commented Apr 22, 2024

@DeepDiver1975 Can we please get this merged and released? This issue prevents me from updating production code to 1.x

@DeepDiver1975
Copy link
Collaborator

Generally speaking I'd prefer to have dedicated pull requests for dedicated topics/issues.
Let's see what CI tells us and then we cut it into dedicated chunks.

THX a lot

@DeepDiver1975
Copy link
Collaborator

The hard dependency on phpunit causes issues to run ci on php 7.x .... please remove.

@hexmode
Copy link
Author

hexmode commented Apr 22, 2024

Generally speaking I'd prefer to have dedicated pull requests for dedicated topics/issues. Let's see what CI tells us and then we cut it into dedicated chunks.

I'll roll back all but my own changes here.

@hexmode hexmode force-pushed the master branch 2 times, most recently from 2922ad4 to dd299ba Compare April 22, 2024 14:26
Also add phpunit dependency, add test target, and fix up phpunit.xml.dist.
@hexmode
Copy link
Author

hexmode commented Apr 22, 2024

fwiw, phpunit dep worked for me on php 7.4 just now but I've removed it as requested.

@hexmode
Copy link
Author

hexmode commented Apr 22, 2024

Given the failures on php 7.0, the options are dropping support 7.0 (my preference, since it is EOL) or dropping the type hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return types are too strict
3 participants