Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lieb_ando: use partially specified problem to get correct vexity #684

Merged
merged 5 commits into from
May 21, 2024

Conversation

ericphanson
Copy link
Collaborator

@ericphanson ericphanson commented May 21, 2024

This is in fact the approach used in CVXQUAD (https://github.com/hfawzi/cvxquad/blob/master/lieb_ando.m), but we didn't have those yet at the time.

This way we don't have to create an atom! Pretty convenient.

Also: I noticed in many of the CVXQUAD-derived atoms, we expect some variables to be PSD, but don't check or enforce it. Could be something we might want to do.

closes #683

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.20%. Comparing base (2978c32) to head (9441aef).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #684   +/-   ##
=======================================
  Coverage   98.19%   98.20%           
=======================================
  Files          89       89           
  Lines        5162     5168    +6     
=======================================
+ Hits         5069     5075    +6     
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericphanson
Copy link
Collaborator Author

unexpected/unrelated docs failure:

ERROR: LoadError: LoadError: ArgumentError: Package TimeZones does not have RecipesBase in its dependencies:
- If you have TimeZones checked out for development and have
  added RecipesBase as a dependency but haven't updated your primary
  environment's manifest file, try `Pkg.resolve()`.
- Otherwise you may need to report an issue with TimeZones

@odow
Copy link
Member

odow commented May 21, 2024

I just restarted it. The TimeZones release is only 2 hours old: https://github.com/JuliaTime/TimeZones.jl/releases/tag/v1.16.0, so I wonder if it's an issue with the cache

@odow
Copy link
Member

odow commented May 21, 2024

Ha. I just arrived at JuliaTime/TimeZones.jl#459 (comment) to find you there too.

As a work-around, we can update the docs to build on Julia 1.10

@ericphanson
Copy link
Collaborator Author

yeah, that works. I put up a patch also: JuliaTime/TimeZones.jl#461

@odow odow merged commit 7a8c0df into master May 21, 2024
10 checks passed
@odow odow deleted the eph/lieb-ando branch May 21, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

lieb_ando reformulation doesn't propogate DCP information correctly
2 participants