Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Solvers #196

Merged
merged 7 commits into from
Mar 8, 2022
Merged

Simplify Solvers #196

merged 7 commits into from
Mar 8, 2022

Conversation

joaquimg
Copy link
Member

@joaquimg joaquimg commented Mar 7, 2022

Close #165
Close #172
Close #182

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #196 (78c21c6) into master (833b023) will increase coverage by 8.84%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   80.52%   89.36%   +8.84%     
==========================================
  Files           8        8              
  Lines         837      837              
==========================================
+ Hits          674      748      +74     
+ Misses        163       89      -74     
Impacted Files Coverage Δ
src/moi_wrapper.jl 85.22% <92.59%> (+28.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 833b023...78c21c6. Read the comment docs.

@joaquimg
Copy link
Member Author

joaquimg commented Mar 7, 2022

MOI Unit tests commented out:

                "test_conic_linear_VectorOfVariables_2",
                "test_attribute_SolverVersion",

Suggestions for solver version? inner solver? diffopt version? both?
ex: "DiffOpt=x.y.z with $(solvername)=a.b.c"?

conic_linear error is:

test_conic_linear_VectorOfVariables_2: Error During Test at C:\Users\joaquimgarcia\.julia\packages\MathOptInterface\FHFUH\src\Test\test_conic.jl:357
  Test threw exception
  Expression: ≈(MOI.get(model, MOI.ConstraintDual(), vs), T[7], config)
  ArgumentError: Bridge of type `MathOptInterface.Bridges.Variable.ZerosBridge{Float64}` does not support accessing the attribute `MathOptInterface.ConstraintDual(1)`. If you encountered this error unexpectedly, it probably means your model has been reformulated using the bridge, and you are attempting to query an attribute that we haven't implemented yet for this bridge. Please open an issue at https://github.com/jump-dev/MathOptInterface.jl/issues/new and provide a reproducible example explaining what you were trying to do.
  Stacktrace:
    [1] get(#unused#::MathOptInterface.Bridges.LazyBridgeOptimizer{HiGHS.Optimizer}, attr::MathOptInterface.ConstraintDual, bridge::MathOptInterface.Bridges.Variable.ZerosBridge{Float64})

@joaquimg
Copy link
Member Author

joaquimg commented Mar 7, 2022

@blegat and @matbesancon, for me we can tag a new version as soon as we merge this. Also probably fine merging even with those two excludes.

@matbesancon
Copy link
Collaborator

I'll let @blegat take a look at the last error before merging. The SolverVersion attribute is not urgent

@joaquimg joaquimg requested a review from blegat March 7, 2022 14:24
@joaquimg joaquimg merged commit 79be897 into master Mar 8, 2022
@matbesancon matbesancon deleted the jg/tests branch April 5, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add ;'s in Thermal_Generation_Dispatch_Example Add new MOI tests Minimize number of solvers for testing
3 participants