Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fix JuMPExtension print tests #1713

Merged
merged 11 commits into from Jan 6, 2019
Merged

✅ Fix JuMPExtension print tests #1713

merged 11 commits into from Jan 6, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 30, 2018

The only change in JuMP.Model printing done by this PR is that the objective function type displayed is now the JuMP type and not the MOI type but I think it is better that way.

Closes #1710

@blegat blegat added this to the 0.19 milestone Dec 30, 2018
@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #1713 into master will increase coverage by 0.1%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1713     +/-   ##
========================================
+ Coverage   68.69%   68.8%   +0.1%     
========================================
  Files          30      30             
  Lines        3891    3901     +10     
========================================
+ Hits         2673    2684     +11     
+ Misses       1218    1217      -1
Impacted Files Coverage Δ
src/nlp.jl 64.78% <100%> (+0.17%) ⬆️
src/print.jl 75.18% <87.87%> (+0.67%) ⬆️
src/macros.jl 84.52% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8dbe5...3b6861f. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 30, 2018

Codecov Report

Merging #1713 into master will increase coverage by 1.76%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
+ Coverage   68.69%   70.45%   +1.76%     
==========================================
  Files          30       30              
  Lines        3891     4262     +371     
==========================================
+ Hits         2673     3003     +330     
- Misses       1218     1259      +41
Impacted Files Coverage Δ
src/nlp.jl 71.8% <100%> (+7.19%) ⬆️
src/print.jl 75.46% <89.18%> (+0.94%) ⬆️
src/macros.jl 84.52% <0%> (+0.18%) ⬆️
src/JuMP.jl 71.79% <0%> (+1.08%) ⬆️
src/variables.jl 84.24% <0%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe719c5...c8d6ef4. Read the comment docs.

src/print.jl Show resolved Hide resolved
src/print.jl Outdated Show resolved Hide resolved
test/print.jl Outdated Show resolved Hide resolved
src/print.jl Show resolved Hide resolved
src/nlp.jl Outdated Show resolved Hide resolved
src/nlp.jl Outdated Show resolved Hide resolved
src/print.jl Outdated Show resolved Hide resolved
test/print.jl Outdated Show resolved Hide resolved
test/print.jl Show resolved Hide resolved
@blegat blegat merged commit 8e810c5 into master Jan 6, 2019
@blegat blegat deleted the bl/jumpextprint branch January 6, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants