Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce CI load by skipping Julia 1.1, 1.2, and 1.3 #2269

Merged
merged 4 commits into from Jul 10, 2020
Merged

Conversation

odow
Copy link
Member

@odow odow commented Jul 10, 2020

I think it is fine for us to only test the LTS release and the most current minor release.

.travis.yml Outdated
- 1.1
- 1.2
- 1.3
# - 1.1 # Disable to speed up CI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a d at the end of Disable

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #2269 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2269      +/-   ##
==========================================
- Coverage   91.41%   91.12%   -0.29%     
==========================================
  Files          42       42              
  Lines        4193     4192       -1     
==========================================
- Hits         3833     3820      -13     
- Misses        360      372      +12     
Impacted Files Coverage Δ
src/Containers/vectorized_product_iterator.jl 35.71% <0.00%> (-7.15%) ⬇️
src/mutable_arithmetics.jl 85.71% <0.00%> (-6.35%) ⬇️
src/Containers/SparseAxisArray.jl 74.64% <0.00%> (-4.52%) ⬇️
src/copy.jl 88.00% <0.00%> (-4.00%) ⬇️
src/Containers/DenseAxisArray.jl 85.29% <0.00%> (-1.97%) ⬇️
src/operators.jl 87.67% <0.00%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70fe5a1...900dc3e. Read the comment docs.

@odow
Copy link
Member Author

odow commented Jul 10, 2020

It also seems like travis builds both the PR and the push.

Should we add:

branches:
  only:
    - master
    - /^release-.*$/

@odow odow merged commit 29f64d8 into master Jul 10, 2020
@odow odow deleted the odow-patch-3 branch July 10, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants