Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format for JuliaFormatter v1.0.15 #3130

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Update format for JuliaFormatter v1.0.15 #3130

merged 4 commits into from
Nov 15, 2022

Conversation

odow
Copy link
Member

@odow odow commented Nov 14, 2022

Changes are because of domluna/JuliaFormatter.jl#653

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 97.65% // Head: 97.65% // No change to project coverage 👍

Coverage data is based on head (26c2ba2) compared to base (8827a96).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3130   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files          33       33           
  Lines        4383     4383           
=======================================
  Hits         4280     4280           
  Misses        103      103           
Impacted Files Coverage Δ
src/lp_sensitivity2.jl 97.76% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow
Copy link
Member Author

odow commented Nov 15, 2022

The docs keep getting stuck at

image

Trying to debug locally.

@odow
Copy link
Member Author

odow commented Nov 15, 2022

Last working build was https://github.com/jump-dev/JuMP.jl/actions/runs/3415196855/jobs/5684053052

Working

  [a93c6f00] + DataFrames v1.4.2
  [cd3eb016] + HTTP v1.5.2
  [91a5bcdd] + Plots v1.36.0
  [d1d4a3ce] + BitFlags v0.1.5
  [ea2cea3b] + Qt5Base_jll v5.15.3+1

Differences between then and now are

  [a93c6f00] + DataFrames v1.4.3
  [cd3eb016] + HTTP v1.5.4
  [91a5bcdd] + Plots v1.36.1
  [d1d4a3ce] + BitFlags v0.1.6
  [ea2cea3b] + Qt5Base_jll v5.15.3+2

Can reproduce the hang locally, can't interrupt with CTRL+C, but the terminal header has gksqt which is a giveaway as to the cause.

@odow
Copy link
Member Author

odow commented Nov 15, 2022

Despite the very suspicious changes in Plots, Qt5Base_jll, and DataFrames, it looks like this might actually have been in HTTP!

@odow
Copy link
Member Author

odow commented Nov 15, 2022

Looks like the culprit was JuliaWeb/HTTP.jl#960

@odow odow merged commit 67b92bc into master Nov 15, 2022
@odow odow deleted the od/update-format branch November 15, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant