[docs] Update how setup the HTTP server in web_app.jl #3131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.65% // Head: 97.65% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3131 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 33 33
Lines 4383 4383
=======================================
Hits 4280 4280
Misses 103 103 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Urgh. Running the file works locally: julia> include("docs/src/tutorials/applications/web_app.jl")
[ Info: Precompiling JuMP [4076af6c-e467-56ae-b986-b466b2749572]
[ Info: Listening on: 127.0.0.1:8080
[ Info: Server on 127.0.0.1:8080 closingPerhaps that's why I ended up with what I originally had. |
|
Sorry for the breakage; this was fixed pretty quickly in the https://github.com/JuliaWeb/HTTP.jl/releases/tag/v1.5.3 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@quinnj: your recent PR to HTTP.jl, JuliaWeb/HTTP.jl#960, broke the JuMP documentation.
See here for the debugging: #3130
We use HTTP in a tutorial to explain how to put a JuMP model behind a web server:
https://jump.dev/JuMP.jl/stable/tutorials/applications/web_app/
Is this fix the right way for us to setup the server? In somewhat poor form, I want to run the server and call it as a client from the same instance of Julia, just to simplify the process of building the documentation.