Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove second SDP relaxation in OPF tutorial due to unreliable numerics. #3432

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

jd-foster
Copy link
Collaborator

Closes #3431.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (736e49e) 97.97% compared to head (91419b1) 97.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3432   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files          34       34           
  Lines        4979     4979           
=======================================
  Hits         4878     4878           
  Misses        101      101           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mortenpi
Copy link
Contributor

The build passes on my machine as well now with this branch!

@blegat
Copy link
Member

blegat commented Jul 15, 2023

I'm wondering whether Hypatia would work better for this example since it supports Hermitian PSD natively.

@odow
Copy link
Member

odow commented Jul 20, 2023

I'd prefer to minimize the number of solvers used in the documentation, so let's just remove this example for now.

@odow odow merged commit f220e9b into master Jul 20, 2023
12 checks passed
@odow odow deleted the jdf/reduce-opf branch July 20, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Documentation fails to build locally
4 participants