[Utilities] refactor src/Utilties/model.jl #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version was not ordered, obscured the structs on which it operated until the very end, and used eval to save a few lines. This made it hard to read, hard to understand, and hard to identify which methods were needed, missing, or incorrect.
odow
force-pushed
the
od/utilities-model
branch
from
a493c68
to
a65d715
Compare
blegat
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the most important files in MOI because
Utilities.Modelgets used by almost every package.The previous version was not ordered, obscured the structs on which it operated until the very end, and used eval to save a few lines.
This made it hard to read, hard to understand, and hard to identify which methods were needed, missing, or incorrect.
The diff is quite bad, but it's just moving things around. No code changes except #2286.