Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler side_dimension_for_vectorized_dimension #2356

Merged
merged 3 commits into from Dec 10, 2023
Merged

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 10, 2023

As a double check, there does not seem to be any difference until 100 millions.

findall(m -> isqrt(2m) != div(isqrt(1 + 8m), 2), 1:100000000)
Int64[]

@chriscoey
Copy link
Contributor

Fascinating

@blegat
Copy link
Member Author

blegat commented Dec 10, 2023

It came up when trying to understand the link between isqrt(2m) which is used by SDPLR and the Barvinok-Pataki bound in jump-dev/SDPLR.jl#11. Once I had this 2-line arguments, it clarified things a lot 😄

@odow
Copy link
Member

odow commented Dec 10, 2023

I guess, just as proof, because @blegat's original example has a typo:

julia> findall(n -> isqrt(2n) != div(isqrt(1 + 8n), 2), 1:100_000_000)
Int64[]

@odow odow merged commit 0d718a0 into master Dec 10, 2023
17 checks passed
@odow odow deleted the bl/side_dim_from_dim branch December 10, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants