Add Variable.SOCtoRSOCBridge #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
force-pushed
the
bl/var_soc_to_rsoc
branch
3 times, most recently
from
0a815d6
to
6223ee8
Compare
blegat
force-pushed
the
bl/var_soc_to_rsoc
branch
from
6223ee8
to
324e436
Compare
Codecov Report
@@ Coverage Diff @@
## master #865 +/- ##
==========================================
- Coverage 94.96% 94.79% -0.18%
==========================================
Files 73 77 +4
Lines 8009 8103 +94
==========================================
+ Hits 7606 7681 +75
- Misses 403 422 +19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, adding SOC variables to PSD solvers not supporting SOC is inefficient as it will go through constraint bridges and create slack variables.
This PR adds SOCtoRSOCBridge to improve the situation.
We also create a different
unbridged_mapas SOCtoRSOCBridge could not implement the current one which fallbacks on the previous one to avoid breakage for bridge implementing it.