Add variable indices context to variable bridges #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
force-pushed
the
bl/variable_bridges_context
branch
from
bb106f6
to
b385d1b
Compare
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
+ Coverage 95.24% 95.25% +0.01%
==========================================
Files 83 83
Lines 8895 8940 +45
==========================================
+ Hits 8472 8516 +44
- Misses 423 424 +1
Continue to review full report at Codecov.
|
As the variable bridges substitute user (bridged) variables into solver variables, the solver and the bridges that are created by this bridge are using the solver variables while the user and other bridges are using the user variables. Before this commit, the solver variables where substituted for the user variables even when the call was coming from a bridge that was created (directly or indirectly) by the bridge that created these variables. This causes issues if the call was for getting a function which should then be converted into a VectorOfVariables as even if it is a VectorOfVariables in terms of the solver variables, it may not be a VectorOfVariables in terms of the user variables.
blegat
force-pushed
the
bl/variable_bridges_context
branch
from
b385d1b
to
c3236c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the variable bridges substitute user (bridged) variables into
solver variables, the solver and the bridges that are created by this bridge are
using the solver variables while the user and other bridges are using
the user variables.
Before this commit, the solver variables where substituted for the user
variables even when the call was coming from a bridge that was created
(directly or indirectly) by the bridge that created these variables.
This causes issues if the call was for getting a function which should
then be converted into a VectorOfVariables as even if it is a
VectorOfVariables in terms of the solver variables, it may not be a
VectorOfVariables in terms of the user variables.