Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MathOptFormat.jl as FileFormats submodule #969

Merged
merged 128 commits into from Dec 29, 2019
Merged

Add MathOptFormat.jl as FileFormats submodule #969

merged 128 commits into from Dec 29, 2019

Conversation

odow
Copy link
Member

@odow odow commented Dec 9, 2019

Closes #28
Closes #633

I can't seem to figure out how to rebase and squash the initial commits without screwing up the unrelated-histories part of Git. If we're okay adding this many commits, then I won't change anything. Otherwise I might need to try take III of this and squash the history a bit before I merge the repos.

blegat and others added 6 commits December 6, 2019 07:49
* Re-organize to reflect JuMP requirements

* Improve coverage

* Bump version

* Simplify handling of compression formats

* Rename new_model -> Model

* Simplify handling of arguments in Model

* Allow passing both arguments to model

* Pass kwargs to model
* Add support for SDPA

* Add tests

* Add test with maximum objective

* [ci skip] Add SDPA to supported formats in README

* Algoithme -> Algorithme

* Get tests passing
@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #969 into master will increase coverage by 0.2%.
The diff coverage is 96.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #969     +/-   ##
=========================================
+ Coverage   95.06%   95.26%   +0.2%     
=========================================
  Files          87       97     +10     
  Lines        9377    10789   +1412     
=========================================
+ Hits         8914    10278   +1364     
- Misses        463      511     +48
Impacted Files Coverage Δ
src/MathOptInterface.jl 100% <ø> (ø) ⬆️
src/FileFormats/SDPA/SDPA.jl 100% <100%> (ø)
src/FileFormats/MOF/MOF.jl 100% <100%> (ø)
src/FileFormats/FileFormats.jl 100% <100%> (ø)
src/FileFormats/MOF/nonlinear.jl 100% <100%> (ø)
src/FileFormats/MOF/write.jl 67.77% <67.77%> (ø)
src/FileFormats/MOF/read.jl 92.98% <92.98%> (ø)
src/FileFormats/utils.jl 95.45% <95.45%> (ø)
src/FileFormats/LP/LP.jl 97.64% <97.64%> (ø)
src/FileFormats/MPS/MPS.jl 99.23% <99.23%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633bb7c...3beed00. Read the comment docs.

@odow
Copy link
Member Author

odow commented Dec 9, 2019

This PR is blocked until I sort the Windows failures on JSONSchema.jl. That package could use some love, but it's not too long, so I'll wait to see if the developer is responsive, otherwise I'll fork and tidy myself.

@blegat
Copy link
Member

blegat commented Dec 9, 2019

We should add something in the doc

@odow
Copy link
Member Author

odow commented Dec 23, 2019

This is ready on my end. I now have commit access to JSONSchema.jl and I'm planning on making some improvements, so it seems okay to add as a dependency.

docs/src/apimanual.md Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
docs/src/apimanual.md Outdated Show resolved Hide resolved
@odow
Copy link
Member Author

odow commented Dec 24, 2019

Are we okay if I merge this with all 127 commits? It's a little untidy, but I don't know how to make it neater.

@blegat
Copy link
Member

blegat commented Dec 25, 2019

Are we okay if I merge this with all 127 commits? It's a little untidy, but I don't know how to make it neater.

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Read/write from/to file should be IO not filenames A File-format for MathOpt
8 participants