New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MathOptFormat.jl as FileFormats submodule #969
Conversation
license: MIT authors: odow years: 2017 user: odow Julia Version 0.6.0 [903644385b*]
* Re-organize to reflect JuMP requirements * Improve coverage * Bump version * Simplify handling of compression formats * Rename new_model -> Model * Simplify handling of arguments in Model * Allow passing both arguments to model * Pass kwargs to model
* Add support for SDPA * Add tests * Add test with maximum objective * [ci skip] Add SDPA to supported formats in README * Algoithme -> Algorithme * Get tests passing
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
=========================================
+ Coverage 95.06% 95.26% +0.2%
=========================================
Files 87 97 +10
Lines 9377 10789 +1412
=========================================
+ Hits 8914 10278 +1364
- Misses 463 511 +48
Continue to review full report at Codecov.
|
This PR is blocked until I sort the Windows failures on JSONSchema.jl. That package could use some love, but it's not too long, so I'll wait to see if the developer is responsive, otherwise I'll fork and tidy myself. |
We should add something in the doc |
This is ready on my end. I now have commit access to JSONSchema.jl and I'm planning on making some improvements, so it seems okay to add as a dependency. |
Are we okay if I merge this with all 127 commits? It's a little untidy, but I don't know how to make it neater. |
Sounds good |
Closes #28
Closes #633
I can't seem to figure out how to rebase and squash the initial commits without screwing up the unrelated-histories part of Git. If we're okay adding this many commits, then I won't change anything. Otherwise I might need to try take III of this and squash the history a bit before I merge the repos.