Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use variable bridge if it is optimal #973

Merged
merged 3 commits into from Dec 19, 2019
Merged

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 18, 2019

Caught by SolverTests with ECOS and SCS: https://travis-ci.com/blegat/SolverTests

@blegat blegat added this to the v0.9.8 milestone Dec 18, 2019
@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #973 into master will decrease coverage by <.01%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #973      +/-   ##
=========================================
- Coverage   95.11%   95.1%   -0.01%     
=========================================
  Files          87      87              
  Lines        9376    9379       +3     
=========================================
+ Hits         8918    8920       +2     
- Misses        458     459       +1
Impacted Files Coverage Δ
src/Bridges/Variable/single_bridge_optimizer.jl 36.36% <0%> (-3.64%) ⬇️
src/Bridges/graph.jl 100% <100%> (+0.91%) ⬆️
src/Bridges/lazy_bridge_optimizer.jl 96.85% <100%> (+0.02%) ⬆️
src/Bridges/debug.jl 96.74% <100%> (ø) ⬆️
src/Bridges/bridge_optimizer.jl 95.43% <60%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071e06d...1241879. Read the comment docs.

@blegat blegat merged commit 9ccb510 into master Dec 19, 2019
@odow odow deleted the bl/check_variable_bridge branch December 30, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants