Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileFormats.MOF] add support for MOF@1.7 #2298

Merged
merged 3 commits into from Sep 28, 2023
Merged

[FileFormats.MOF] add support for MOF@1.7 #2298

merged 3 commits into from Sep 28, 2023

Conversation

odow
Copy link
Member

@odow odow commented Sep 28, 2023

x-ref jump-dev/MathOptFormat#35

At the expense of type-stability, this makes things a lot simpler. But the rest of the nonlinear work showed that this shouldn't matter. And any other implementation is going to have to deal with the type ambiguity of variable/real/operator anyway.

Basic

  • The file at src/FileFormats/MOF/mof.schema.json is updated
  • The constant _SUPPORTED_VERSIONS is updated in
    src/FileFormats/MOF/MOF.jl

New sets

  • New sets are added to the @model in src/FileFormats/MOF/MOF.jl
  • New sets are added to the @enum in src/FileFormats/MOF/read.jl
  • set_to_moi is defined for each set in src/FileFormats/MOF/read.jl
  • head_name is defined for each set in src/FileFormats/MOF/write.jl
  • A new unit test calling _test_model_equality is aded to
    test/FileFormats/MOF/MOF.jl

Tests

  • The version field in test/FileFormats/MOF/nlp.mof.json is updated

Documentation

  • The version fields are updated in docs/src/submodules/FileFormats/overview.md

Project.toml Outdated Show resolved Hide resolved
@odow odow merged commit be4d854 into master Sep 28, 2023
16 of 17 checks passed
@odow odow deleted the od/mof-1.7 branch September 28, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant