New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up somewhat and use new MOI.Test tests #43
Conversation
We don't have a way of doing this because it's a pretty uncommon ask. You'd have to manually exclude them. you can also partially match function names. So you could have |
Thanks. Given how many need to be excluded, could it make more sense to just list the ones to include? I assume that is what the "include = ..." is for. |
Yes, that's what
This seems like the way to go. |
Ok I'll try that. And should I do the module wrapping of MOI tests that I think I've seen in some other packages recently? Or is that not really important? |
It's not necessary, but putting thing in a module gets rid of a bunch of scoping and global variable issues (it's too common for tests to accidentally rely on data/variables set in other parts (or files) or the tests). |
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
===========================================
+ Coverage 69.82% 85.76% +15.93%
===========================================
Files 3 4 +1
Lines 570 583 +13
===========================================
+ Hits 398 500 +102
+ Misses 172 83 -89
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had a look through, but you may as well merge if the tests are passing. I'll take a better look this week once I've made the changes the MOI.
@blegat @odow what is the simplest way to select the right set of MOI.Test functions to include/exclude? With the first commit here, there are dozens of MOI test functions that fail - too many to list by hand. Many fail because Pavito errors on instances without integer/discrete constraints, but I don't know a simple way to exclude all instances without such constraints.