Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v7.3.17 #57

Merged
merged 11 commits into from Mar 7, 2024
Merged

Update to v7.3.17 #57

merged 11 commits into from Mar 7, 2024

Conversation

odow
Copy link
Member

@odow odow commented May 18, 2023

I haven't tested, so lets see if anything broke

Closes #56

@odow odow mentioned this pull request May 18, 2023
@odow odow changed the title Support CxxWrap v0.13 Fix and test on nightly May 18, 2023
@odow
Copy link
Member Author

odow commented May 18, 2023

SDPA_jll rebuilding JuliaPackaging/Yggdrasil#6760

@odow odow closed this May 18, 2023
@odow odow reopened this May 18, 2023
@odow
Copy link
Member Author

odow commented May 18, 2023

Now it looks like we've broken Windows

@blegat
Copy link
Member

blegat commented Feb 19, 2024

The failure on CI should hopefully be fixed by JuliaPackaging/Yggdrasil#8130

Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
@blegat
Copy link
Member

blegat commented Feb 21, 2024

Maybe there is an issue with the fact that we updated SDPA but not MUMPS while the new version of SDPA uses the new version of MUMPS.

@odow
Copy link
Member Author

odow commented Feb 21, 2024

I have no idea.

@blegat
Copy link
Member

blegat commented Feb 22, 2024

The only MUMPS-related change I see from v7.3.8 to v7.3.16 is
blegat/SDPA@d0231ac#diff-bfa35ecf42cf12cbd937e1688e5a308213948a879405125f6f885e6ea80ec211R110-R114

@blegat
Copy link
Member

blegat commented Feb 22, 2024

@barche any chance you have already seen such error when updating to CxxWrap v0.14 and have any idea ?

@barche
Copy link

barche commented Feb 27, 2024

I'm sorry for the late response, this is a compat issue: CxxWrap 0.14 is based on libcxxwrap_julia_jll 0.11, but SDPA_jll in Yggdrasil is compiled against libcxxwrap_julia_jll version 0.12.

I should be able to release the next CxxWrap (0.15) soon, but this will also contain an updated libcxxwrap, so possibly you will need to rebuild the SPDA_JLL against that. I just tried this branch locally and it works with CxxWrap#testjll and a CxxWrap compat for CxxWrap 0.15.

@odow
Copy link
Member Author

odow commented Feb 28, 2024

Ah! For now, I'll rebuild with libcxxwrap_julia_jll@0.11

I guess the problem was an appropriate compat in SDDP_jll

https://github.com/JuliaBinaryWrappers/SDPA_jll.jl/blob/c3fc3fd01a12a410aefd908bf41e168cc9ef02c6/Project.toml#L8

x-ref JuliaPackaging/Yggdrasil#8206

Project.toml Outdated Show resolved Hide resolved
@odow
Copy link
Member Author

odow commented Mar 7, 2024

Looks like we hit JuliaPackaging/Yggdrasil#7904

@blegat
Copy link
Member

blegat commented Mar 7, 2024

Maybe we can merge since it's still an improvement over master that doesn't work on Julia v1.10 for any OS

@odow odow changed the title Fix and test on nightly Update to v7.3.17 Mar 7, 2024
@odow odow merged commit 5030eea into master Mar 7, 2024
8 of 9 checks passed
@odow odow deleted the odow-patch-1 branch March 7, 2024 18:54
@odow
Copy link
Member Author

odow commented Mar 8, 2024

So it took us a year, but we got there in the end. Thanks all for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rebuild JLL for Julia 1.10
3 participants