-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: fix partner theme footer-image #1134
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if configTheme?.hasBackgroundGradient
is not true it essentially returns nothing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@admsk2 Pretty much, in that case it will just be the "container" which is rendered. The gradients (top, bottom-left + bottom-right) are optional depending on "hasBackgroundGradient".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, maybe that code would be easier to understand:
import { useSuperfest } from 'src/hooks/useSuperfest';
import { PartnerThemeFooterImage } from '../PartnerThemeFooterImage';
import { SuperfestBackgroundContainer } from './BackgroundGradient.style';
const SuperfestBackground = () => {
const { isSuperfest } = useSuperfest();
// Only render the container and contents if isSuperfest is false
if (isSuperfest) {
return null;
}
return (
<SuperfestBackgroundContainer>
<PartnerThemeFooterImage />
</SuperfestBackgroundContainer>
);
};
export default SuperfestBackground;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@admsk2 Good point! Here, we also return the container as default background and optionally add the partner-theme footer-image. So, returning null would not work afaik.
@dennyscode we have lost the logo on page like: https://jumper-exchange-git-fix-partner-footer-l-3d2127-jumper-exchange.vercel.app/fr/superfest/rewards-from-aave-on-base/. Can you give it a look? |
Partner-Theme footer image not overlapping the widget anymore.
! The Widget-Container with width of 100% does not allow mouse-events across all screensizes.