Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix partner theme footer-image #1134

Closed
wants to merge 14 commits into from

Conversation

dennyscode
Copy link
Contributor

image

Partner-Theme footer image not overlapping the widget anymore.

! The Widget-Container with width of 100% does not allow mouse-events across all screensizes.

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jumper-exchange ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 2:02pm

@dennyscode dennyscode changed the title style: fix partner theme image style: fix partner theme footer-image Jul 18, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if configTheme?.hasBackgroundGradient is not true it essentially returns nothing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@admsk2 Pretty much, in that case it will just be the "container" which is rendered. The gradients (top, bottom-left + bottom-right) are optional depending on "hasBackgroundGradient".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, maybe that code would be easier to understand:

import { useSuperfest } from 'src/hooks/useSuperfest';
import { PartnerThemeFooterImage } from '../PartnerThemeFooterImage';
import { SuperfestBackgroundContainer } from './BackgroundGradient.style';

const SuperfestBackground = () => {
  const { isSuperfest } = useSuperfest();
  
  // Only render the container and contents if isSuperfest is false
  if (isSuperfest) {
    return null;
  }

  return (
    <SuperfestBackgroundContainer>
      <PartnerThemeFooterImage />
    </SuperfestBackgroundContainer>
  );
};

export default SuperfestBackground;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@admsk2 Good point! Here, we also return the container as default background and optionally add the partner-theme footer-image. So, returning null would not work afaik.

@tcheee
Copy link
Contributor

tcheee commented Jul 29, 2024

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants