Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump CI scripts to use R 4.3 and bioconductor 3.18 #29

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

russHyde
Copy link
Collaborator

CI (linting / package checks) were failing in mrc-ide/tfpscanner because the package dependencies couldn't be installed. The original CI scripts used bioconductor 3.16 and R 4.2. Here we bump these to bioconductor 3.18 and R 4.3

In an experimental PR against mrc-ide/tfpscanner:main both CI scripts ran without error after these changes.

@russHyde russHyde requested a review from timbrock March 19, 2024 11:48
@russHyde
Copy link
Collaborator Author

russHyde commented Mar 19, 2024

See here for the successful CI runs in mrc-ide/tfpscanner: https://github.com/mrc-ide/tfpscanner/pull/12/checks
See here for the failed installation CI runs: mrc-ide#11

The installation problem in that failure may be due to introduction of renv, or may be due to use of the old bioconductor 3.16 (and most likely due to a bit of both, because the renv spec used packages from bioconductor 3.18). The changes here just allow us to use the newer version of bioconductor.

@russHyde russHyde merged commit 93b346f into dev-202403 Mar 21, 2024
@russHyde russHyde deleted the fix-ci branch March 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants