All features 202403 #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that a {renv}-based environment is defined in here. This can be used to ensure that the output from |
russHyde
force-pushed
the
draft-all-features-202403
branch
from
0959c9e
to
78d7948
Compare
|
The CI runs work fine against Bioconductor 3.18 / R 4.3. But if an {renv} definition is present, we get failures to install system packages. Suggest that the way to ensure the figures are generated using a matching environment to the browser app is by making a figure-generating env within tfpbrowser, rather than having an in-package env here. |
bump CI scripts to use R 4.3 and bioconductor 3.18
russHyde
force-pushed
the
draft-all-features-202403
branch
from
78d7948
to
b5f96b2
Compare
russHyde
force-pushed
the
draft-all-features-202403
branch
from
b5f96b2
to
717a136
Compare
russHyde
force-pushed
the
draft-all-features-202403
branch
from
717a136
to
461867c
Compare
Fix heatmap
…Blue-Red diverging palette with light-grey midpoint
…vars in 'save_trees'
…han in (non-exported) save_trees() This makes the function call for save_trees() more similar to save_sina_plot(), where the width and height are specified as function arguments.
russHyde
force-pushed
the
draft-all-features-202403
branch
from
461867c
to
193227d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft branch containing all features from Jumping Rivers' development work on tfpscanner in Feb/March 2024.
This branch is just to allow Erik's team to experiment with the introduced features, while the associated code is under review. The real thing will be merged into mrc-ide/tfpscanner once the source code for individual features has been reviewed. That merge will come from
dev-202403rather than this branch.