Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure #11

Closed
wants to merge 1 commit into from
Closed

Restructure #11

wants to merge 1 commit into from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jul 14, 2019

@junaidbhura What do you think?

@junaidbhura
Copy link
Owner

Hi @szepeviktor Thanks for the pull request!

Could you please elaborate what you mean by "make it like a real composer pkg"?

@szepeviktor
Copy link
Contributor Author

Could you please elaborate what you mean by "make it like a real composer pkg"?

  1. Please pick any well-known Composer package
  2. Look at where its namespace root is
  3. You find that it is in src/

That is why.

@szepeviktor
Copy link
Contributor Author

src/ separates your source files from other files!

@junaidbhura
Copy link
Owner

Understood @szepeviktor . Let me take a look at this pull request at length, and merge it if it all looks okay.

Thanks again!

@junaidbhura
Copy link
Owner

@szepeviktor Unfortunately, as I'd mentioned on the other issue, I'm going to be doing a bit of a re-write of this plugin, which will conflict with the changes you've added.

As such, I'm going to have to close this pull request, sorry about that!

Thanks again for your contribution.

@szepeviktor szepeviktor deleted the restructure branch July 15, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants