Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Season and Episode search clean up #113

Open
VeNoMouS opened this issue Oct 8, 2013 · 3 comments
Open

Provider Season and Episode search clean up #113

VeNoMouS opened this issue Oct 8, 2013 · 3 comments

Comments

@VeNoMouS
Copy link

VeNoMouS commented Oct 8, 2013

Rather than have dupe search code in every provider, create a new centralized helper style class that the provider _get_season_search_strings() and _get_episode_search_strings() functions call, this way it can be managed from one central point rather than each provider be changed.

@dmarcelino
Copy link

Hey @VeNoMouS, was there any progress on this? This sounds like a very good idea and ties in nicely with something I've been thinking. Some (anime) shows have some odd patterns, like for example Mushishi: mushishi s2 - 01.
One potential solution would be to have an additional property for each show to define a custom search pattern. That way shows with odd patterns could be addressed.

@VeNoMouS
Copy link
Author

@junalmeida and I have discussed the issue, we know what needs to be done... @junalmeida is very very busy lately in his personal life, so I've been doing most of the work and I normally only do work on this project in the weekends as I have a day job and family etc... its on the to do list...

Re the anime numbering ... yes we were are aware of this issue, sickrage addressed this issue in their build by adding in a boolean for episode type... I have reviewed their code and understand what would be required to port it over..

Ultimately there is a bit of work around the whole episode searching... refer #192 that i discussed some of the issues.. related this exact problem

@dmarcelino
Copy link

#192 sounds like a good approach for this, I'll monitor that,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants