Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torrents search for "season #" instead of "S0#" #192

Open
maspiter opened this issue Aug 21, 2014 · 4 comments
Open

Torrents search for "season #" instead of "S0#" #192

maspiter opened this issue Aug 21, 2014 · 4 comments
Labels

Comments

@maspiter
Copy link

Hi,

I'm just starting out with sickbeard and already have a suggestion.

I'm having an issue when searching torrents. I want to download the 720p web-dl version of a complete season. Only problem is, sickbeard only searches with i.e. "Sopranos S03" when the version I want to download only returns results when searched for "Sopranos season 3". So, adding an option to search for S0# as well as Season # would be really useful IMO.

That's it for now. Thanks for the plugin and would really appreciate it If you can find the time to look into these suggestions.

@maspiter maspiter changed the title Torrents search for "season #" instead of S0# - KAT proxy config option Torrents search for "season #" instead of "S0#" & KAT proxy config option Aug 21, 2014
@junalmeida
Copy link
Owner

Hello @maspiter. I don't see this as an issue, but both as feature requests. To keep this clean, can you please edit this and separate each one?

SB searches for S03 and this works for all shows I know so far but this that you are reporting (Sopranos). Besides this fact, the search logic is a code written in SB internals, not in torrent providers, and this branch goals are related to torrent providers and subtitles. Anyway, we can investigate how difficult it will be to implement an option to search using "season #".

@maspiter
Copy link
Author

Yeah, regarding the search option, I already figured as much but wasn't behind my computer anymore to edit the post.

The ability to configure a custom KAT proxy would still be handy though.

Thanks for the reply

@maspiter maspiter changed the title Torrents search for "season #" instead of "S0#" & KAT proxy config option Torrents search for "season #" instead of "S0#" Aug 25, 2014
@VeNoMouS
Copy link

Just spent the better part of an hour looking though the code at this... CAN OF WORMS... OPENED... lol yeaaa i found some bad stuff here that needs to fixed..

@VeNoMouS
Copy link

WOW... i just think i worked it ... looping over and over again....

OK... the short story it basically it loops back to each download provider and sickbeard/config.py to

naming_ep_type = ("%(seasonnumber)dx%(episodenumber)02d",
                  "s%(seasonnumber)02de%(episodenumber)02d",
                   "S%(seasonnumber)02dE%(episodenumber)02d",
                   "%(seasonnumber)02dx%(episodenumber)02d")

each provider is hard setting to pull element 2 sickbeard.config.naming_ep_type[2] which is

"S%(seasonnumber)02dE%(episodenumber)02d",

This is being defined in each provider in the functions _get_season_search_strings and _get_episode_search_strings ... namely .. with lines..

ep_string = show_name_helpers.sanitizeSceneName(show_name) +' '+ sickbeard.config.naming_ep_type[2] % {'seasonnumber': season, 'episodenumber': int(sqlEp["episode"])}

And ...

ep_string = show_name_helpers.sanitizeSceneName(show_name) +' '+ sickbeard.config.naming_ep_type[2] % {'seasonnumber': ep_obj.season, 'episodenumber': ep_obj.episode}

This ideally needs to be rewritten to loop the array sickbeard.config.naming_ep_type

Addtionally in your case... a new element needs to be put into naming_ep_type something like

"Season %(seasonnumber)dE%(episodenumber)02d"

Tho... I need to look at this further because i dont understand how its passing that with a pattern with an episode number on a season search...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants