Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1637 show error message when preview command fails #1810

Merged
merged 1 commit into from
Jan 19, 2020

Conversation

tonymet
Copy link
Contributor

@tonymet tonymet commented Jan 5, 2020

fix #1637

STEPS

SHELL=kaka go run .  --preview 'cat {}'

BEFORE:

[preview window is empty]

AFTER

Preview window:

 exec: "kaka": executable file not found in $PATH

Other Testing

test suite pass

 make test > /dev/null && echo $?                                   
0

Test existing behavior with return code ~= 0

  138   go run .  --preview 'cat {} |grep fzf'
  149   go run .  --preview 'cat {} |grep -v fzf'
  152   go run .  --preview 'cat {} |grep -v fzf'

@junegunn junegunn merged commit f246fb2 into junegunn:master Jan 19, 2020
@junegunn
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fzf --preview is empty if $SHELL points to missing file
2 participants