ClanScoreHistory should be created on value changes

junethack · Jun 10, 2015 · 6e23aeb · 6e23aeb
1 parent a3d4d7a
commit 6e23aeb
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/lib/junethack/trophy_calculations.rb b/lib/junethack/trophy_calculations.rb
@@ -494,8 +494,8 @@ def history_clans
     ClanScoreEntry.all.each {|e|
         h = ClanScoreHistory.first(:trophy => e.trophy, :clan_name => e.clan_name, :order => :created_at.desc)
         # only record when points or rank has changed
-        if not h or h.points != e.points or h.rank != e.rank
-            c = ClanScoreHistory.create(e.attributes)
+        if not h or h.points != e.points or h.rank != e.rank or h.value != e.value
+            ClanScoreHistory.create(e.attributes)
         end
     }
 end

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -28,6 +28,7 @@
 
 def clean_database
   ClanScoreEntry.destroy!
+  ClanScoreHistory.destroy!
   Individualtrophy.destroy!
   Scoreentry.destroy!
   NormalizedDeath.destroy!

diff --git a/spec/unittests/trophies_achievements/clan_scores_spec.rb b/spec/unittests/trophies_achievements/clan_scores_spec.rb
@@ -58,4 +58,19 @@ def update_games
     ClanScoreEntry.first(:trophy => :most_medusa_kills).value.should == 1
     ClanScoreHistory.all(:trophy => :most_medusa_kills).count.should == 1
   end
+
+  it "creates clan score history entries if the value of the trophy changes" do
+    attributes = { version: 'v1', server_id: 1, achieve: "0x800", points: 9000, endtime: 1000, death: 'ascended', turns: 1023 }
+    Game.create(attributes)
+    update_games
+    ClanScoreEntry.first(:trophy => :most_medusa_kills).value.should == 1
+    ClanScoreHistory.all(:trophy => :most_medusa_kills).count.should == 1
+
+    Game.create(attributes)
+    update_games
+
+    ClanScoreEntry.first(:trophy => :most_medusa_kills).value.should == 2
+    ClanScoreHistory.all(:trophy => :most_medusa_kills).count.should == 2
+    ClanScoreHistory.all(:trophy => :most_medusa_kills).map(&:value).sort == [1, 2]
+  end
 end