Skip to content

Commit

Permalink
Revert "doc: correct vcbuild options for windows testing"
Browse files Browse the repository at this point in the history
This reverts commit ed9b6c1.

PR-URL: nodejs#10839
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
  • Loading branch information
gibfahn committed Jan 21, 2017
1 parent 492163c commit 93c4820
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ Prerequisites:
To run the tests:

```console
> .\vcbuild nosign test
> .\vcbuild test
```

To test if Node.js was built correctly:
Expand Down Expand Up @@ -180,7 +180,7 @@ $ ./configure --with-intl=full-icu --download=all
##### Windows:

```console
> .\vcbuild nosign full-icu download-all
> .\vcbuild full-icu download-all
```

#### Building without Intl support
Expand All @@ -197,7 +197,7 @@ $ ./configure --without-intl
##### Windows:

```console
> .\vcbuild nosign without-intl
> .\vcbuild without-intl
```

#### Use existing installed ICU (Unix / OS X only):
Expand Down Expand Up @@ -240,7 +240,7 @@ First unpack latest ICU to `deps/icu`
as `deps/icu` (You'll have: `deps/icu/source/...`)

```console
> .\vcbuild nosign full-icu
> .\vcbuild full-icu
```

## Building Node.js with FIPS-compliant OpenSSL
Expand Down
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,19 +170,19 @@ $ ./configure && make -j4 test
Windows:

```text
.\vcbuild nosign test
> vcbuild test
```

(See the [BUILDING.md](./BUILDING.md) for more details.)

Make sure the linter is happy and that all tests pass. Please, do not submit
patches that fail either check.

Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or
Running `make test`/`vcbuild test` will run the linter as well unless one or
more tests fail.

If you want to run the linter without running tests, use
`make lint`/`.\vcbuild nosign jslint`.
`make lint`/`vcbuild jslint`.

If you are updating tests and just want to run a single test to check it, you
can use this syntax to run it exactly as the test harness would:
Expand Down

0 comments on commit 93c4820

Please sign in to comment.