Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions and TypeScript #5

Merged
merged 28 commits into from
Jul 23, 2020
Merged

Conversation

junhoyeo
Copy link
Owner

@junhoyeo junhoyeo commented Jul 22, 2020

Closes #2
Please note that the old source here is something like a rapid sketch, not structured or qualified

  • Parse all user information in GitHub without official API
  • Create type-strong models
  • Migrate storage to MongoDB
  • Provide API for requesting new user to be in allowlist
  • Parse user list from ALLOWLIST
  • Store data with lowdb
  • Render result from template with ejs
  • Deploy script which pushes build files to gh-pages
  • Automate data updates with GitHub Actions

@junhoyeo junhoyeo changed the title [WIP] Migrate to actions [WIP] Migrate to actions with TypeScript Jul 22, 2020
@junhoyeo junhoyeo changed the title [WIP] Migrate to actions with TypeScript [WIP] Migrate to actions with TypeScript, MongoDB Jul 22, 2020
@64json
Copy link

64json commented Jul 22, 2020

Great project and great idea to migrate to GitHub Actions! I have several idea suggestions:

  1. [Migrate storage to MongoDB]: How do you think of uploading the crawled data to GitHub Pages instead of MongoDB? In that way, there's no need to set up a backend server at all, and everything runs on GitHub. (I'm currently using this way for one of my project, and it seems pretty solid.)
  2. [Provide API for requesting new user to be in allowlist]: I think it would be great if you place ALLOWLIST file in the root that contains a username in each line. Then people can easily create a PR by editing the file on GitHub. I believe this way will bring a good amount of stars on this repo!

@junhoyeo
Copy link
Owner Author

junhoyeo commented Jul 22, 2020

Great project and great idea to migrate to GitHub Actions! I have several idea suggestions:

@64json, Thanks for your suggestions! When I decided to start this project at first, I tried to consider that way(leaving all the data in the repo) but as you know, I didn't had any community feedback like now so I just "digged" platforms like GitHub, LinkedIn, etc to find my alumnae. So I thought people in the ALLOWLIST can think this kind of action "rude", if I just start giving out their private data here.
Now that I'm sure that the feedback here is positive, maybe I'll do just like that! 🙂

@junhoyeo junhoyeo changed the title [WIP] Migrate to actions with TypeScript, MongoDB [WIP] Migrate to actions and TypeScript Jul 22, 2020
@junhoyeo junhoyeo changed the title [WIP] Migrate to actions and TypeScript [WIP] Migrate to GitHub Actions and TypeScript Jul 23, 2020
@junhoyeo junhoyeo changed the title [WIP] Migrate to GitHub Actions and TypeScript Migrate to GitHub Actions and TypeScript Jul 23, 2020
@junhoyeo junhoyeo merged commit deef210 into master Jul 23, 2020
@junhoyeo junhoyeo deleted the migrate-to-actions branch July 23, 2020 11:53
@junhoyeo junhoyeo restored the migrate-to-actions branch July 23, 2020 12:01
@junhoyeo junhoyeo deleted the migrate-to-actions branch July 23, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Github Actions
2 participants