Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CartesianTestExtension doesn't support NULL values #764

Closed
petrandreev opened this issue Sep 21, 2023 · 0 comments · Fixed by #765
Closed

CartesianTestExtension doesn't support NULL values #764

petrandreev opened this issue Sep 21, 2023 · 0 comments · Fixed by #765

Comments

@petrandreev
Copy link
Contributor

Version: 2.1.0

CartesianTestExtension fails with NullPointerExtension when, for instance, a custom CartesianParameterArgumentsProvider
provides null values.
org.junit.jupiter.api.extension.ExtensionConfigurationException: Could not provide arguments because of exception. at org.junitpioneer.jupiter.cartesian.CartesianTestExtension.getSetFromAnnotation(CartesianTestExtension.java:113) at org.junitpioneer.jupiter.cartesian.CartesianTestExtension.getSetsFromArgumentsSources(CartesianTestExtension.java:102) at org.junitpioneer.jupiter.cartesian.CartesianTestExtension.computeSets(CartesianTestExtension.java:72) at org.junitpioneer.jupiter.cartesian.CartesianTestExtension.provideTestTemplateInvocationContexts(CartesianTestExtension.java:48) at org.junit.jupiter.engine.descriptor.TestTemplateTestDescriptor.lambda$execute$0(TestTemplateTestDescriptor.java:106) at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:273) at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) at org.junit.jupiter.engine.descriptor.TestTemplateTestDescriptor.execute(TestTemplateTestDescriptor.java:110) at org.junit.jupiter.engine.descriptor.TestTemplateTestDescriptor.execute(TestTemplateTestDescriptor.java:44) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141) at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95) at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35) at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57) at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:55) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:102) at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:54) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86) at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86) at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:118) at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:93) at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:88) at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:62) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36) at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33) at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94) at jdk.proxy2/jdk.proxy2.$Proxy5.stop(Unknown Source) at org.gradle.api.internal.tasks.testing.worker.TestWorker$3.run(TestWorker.java:193) at org.gradle.api.internal.tasks.testing.worker.TestWorker.executeAndMaintainThreadName(TestWorker.java:129) at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:100) at org.gradle.api.internal.tasks.testing.worker.TestWorker.execute(TestWorker.java:60) at org.gradle.process.internal.worker.child.ActionExecutionWorker.execute(ActionExecutionWorker.java:56) at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:113) at org.gradle.process.internal.worker.child.SystemApplicationClassLoaderWorker.call(SystemApplicationClassLoaderWorker.java:65) at worker.org.gradle.process.internal.worker.GradleWorkerMain.run(GradleWorkerMain.java:69) at worker.org.gradle.process.internal.worker.GradleWorkerMain.main(GradleWorkerMain.java:74) Caused by: java.lang.NullPointerException at java.base/java.util.Objects.requireNonNull(Objects.java:209) at java.base/java.util.ImmutableCollections.listFromTrustedArray(ImmutableCollections.java:213) at java.base/java.util.ImmutableCollections$Access$1.listFromTrustedArray(ImmutableCollections.java:124) at java.base/java.util.stream.Collectors.lambda$toUnmodifiableList$6(Collectors.java:303) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:686) at org.junitpioneer.jupiter.cartesian.CartesianTestExtension.provideArguments(CartesianTestExtension.java:167) at org.junitpioneer.jupiter.cartesian.CartesianTestExtension.getSetFromAnnotation(CartesianTestExtension.java:110) ... 76 more
Therefore it is impossible to build cartesian products with NULL arguments.

Introduced while migrating to JDK > v10 in:
5c255d9

image

Possible solution:
see recommended migration paths:
https://4comprehension.com/nulls-against-collectors/
petrandreev added a commit to petrandreev/junit-pioneer that referenced this issue Sep 21, 2023
@petrandreev
test(junit-pioneer#764): allowed CartesianParameterArgumentsProvider …
8b5b9d0 
…to provide NULL values
petrandreev added a commit to petrandreev/junit-pioneer that referenced this issue Sep 21, 2023
@petrandreev
fix(junit-pioneer#764): allowed CartesianParameterArgumentsProvider t…
eaeda25 
…o provide NULL values
petrandreev added a commit to petrandreev/junit-pioneer that referenced this issue Sep 21, 2023
@petrandreev
Add back support for NULL values to Cartesian Argument Providers (jun…
c13baec 
…it-pioneer#764 / ${pull-request})

During migration to JDK11 the support of NULL values
provided by CartesianParameterArgumentsProvider has been silently dropped.

These changes
 - add back support for NULL values and ensure backward compatibility with v. 2.0.1
 - add regression tests for provided NULL values support

Fixes: junit-pioneer#764
@petrandreev petrandreev mentioned this issue Sep 21, 2023
Merged
18 tasks
petrandreev added a commit to petrandreev/junit-pioneer that referenced this issue Sep 21, 2023
@petrandreev
Add back support for NULL values to Cartesian Argument Providers (jun…
a062ed9 
…it-pioneer#764 / junit-pioneer#765)

During migration to JDK11 the support of NULL values
provided by CartesianParameterArgumentsProvider has been silently dropped.

These changes
 - add back support for NULL values and ensure backward compatibility with v. 2.0.1
 - add regression tests for provided NULL values support

Fixes: junit-pioneer#764
petrandreev added a commit to petrandreev/junit-pioneer that referenced this issue Sep 25, 2023
@petrandreev
Add back support for NULL values to Cartesian Argument Providers (jun…
bbb2115 
…it-pioneer#764 / junit-pioneer#765)

During migration to JDK11 the support of NULL values
provided by CartesianParameterArgumentsProvider has been silently dropped.

These changes
 - add back support for NULL values and ensure backward compatibility with v. 2.0.1
 - add regression tests for provided NULL values support

Fixes: junit-pioneer#764
Michael1993 pushed a commit that referenced this issue Sep 26, 2023
@petrandreev
Add back support for NULL values to CartesianTest (#764 / #765)
4cba07c 
During migration to JDK11 the support of NULL values
provided by CartesianParameterArgumentsProvider has been silently dropped.

These changes
 - add back support for NULL values
 - add regression tests for provided NULL values support

Fixes: #764
PR: #765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back support for NULL values to Cartesian Argument Providers petrandreev/junit-pioneer
1 participant
@petrandreev