Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back support for NULL values to Cartesian Argument Providers #765

Conversation

petrandreev
Copy link
Contributor

@petrandreev petrandreev commented Sep 21, 2023

During migration to JDK11 the support of NULL values provided by CartesianParameterArgumentsProvider has been silently dropped.

These changes

  • add back support for NULL values and ensure backward compatibility with v. 2.0.1
  • add regression tests for provided NULL values support

Fixes: #764


PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code (general)

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Code (new package)

  • The new package is exported in module-info.java
  • The new package is also present in the tests
  • The new package is opened for reflection to JUnit 5 in module-info.java
  • The new package is listed in the contribution guide

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

petrandreev added a commit to petrandreev/junit-pioneer that referenced this pull request Sep 21, 2023
…it-pioneer#764 / junit-pioneer#765)

During migration to JDK11 the support of NULL values
provided by CartesianParameterArgumentsProvider has been silently dropped.

These changes
 - add back support for NULL values and ensure backward compatibility with v. 2.0.1
 - add regression tests for provided NULL values support

Fixes: junit-pioneer#764
@petrandreev petrandreev force-pushed the issue/764-allow-null-values-in-cartesian-providers branch from c13baec to a062ed9 Compare September 21, 2023 12:12
Copy link
Member

@Michael1993 Michael1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I did not know about this difference between toList and toUnmodifiableList, thank you! Would you like to add yourself to the README as a contributor? 🙂

…it-pioneer#764 / junit-pioneer#765)

During migration to JDK11 the support of NULL values
provided by CartesianParameterArgumentsProvider has been silently dropped.

These changes
 - add back support for NULL values and ensure backward compatibility with v. 2.0.1
 - add regression tests for provided NULL values support

Fixes: junit-pioneer#764
@petrandreev petrandreev force-pushed the issue/764-allow-null-values-in-cartesian-providers branch from a062ed9 to bbb2115 Compare September 25, 2023 10:40
@petrandreev
Copy link
Contributor Author

Thanks, added

@Michael1993 Michael1993 merged commit 4cba07c into junit-pioneer:main Sep 26, 2023
11 checks passed
@Michael1993
Copy link
Member

@petrandreev Hi!

This PR is already merged, thank you for contributing it! Do you have some thoughts or something specific you'd like to discuss or address? I'm here to help with any concerns you might have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CartesianTestExtension doesn't support NULL values
2 participants