Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate rule that requires issue and PR number in title #273

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

nipafx
Copy link
Member

@nipafx nipafx commented Jun 9, 2020

Proposed commit message:

Require issue and PR number in commit title (#264 / #273)

This was the rule until #79 / #86 changed it. We now consider that a
bad decision and want to start doing it again. An important factor
was that IDEs can make issue and PR numbers clickable links, which
adds additional value to making them easily accessible.

I hereby agree to the terms of the JUnit Pioneer Contributor License Agreement.

@nipafx
Copy link
Member Author

nipafx commented Jun 9, 2020

As soon as the first other maintainer gives thumbs up, the other one can merge this. :)

Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wah I want to revert that.

What about keeping the lower part of the commitmessage, to link, fix/close an issue with an PR/Commit message to avoid manually work on the issue?

@Bukama Bukama self-requested a review June 9, 2020 18:08
@Bukama Bukama added this to the Cleaner Pioneers - V1.0 milestone Jun 11, 2020
@aepfli
Copy link
Member

aepfli commented Jun 13, 2020

actually i do like the refernce block at the bottom. not particularly for closes/fixes - but it could also be used for referencing other topics to give more context. Also the manual part @Bukama is talking about, is something we should verify, if this is also the case for ticket numbers in the title

Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add information at bottom of commit message (see our comments)

@nipafx nipafx merged commit 45e1ab2 into master Jun 16, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nipafx nipafx deleted the issue/264-commit-title branch June 20, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants