Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.12 Release #616

Closed
gaffa opened this issue Jan 21, 2013 · 33 comments
Closed

4.12 Release #616

gaffa opened this issue Jan 21, 2013 · 33 comments
Milestone

Comments

@gaffa
Copy link
Contributor

gaffa commented Jan 21, 2013

Hi!
As I did not know where else to ask I am opening an issue for this. I am wondering what is holding back the 4.12 release and when it is going to be released. If anyone can provide me with a public maven repository containing a beta-release I would be grateful as well as I would like to use some of the features in our build soon.
Regards, Henning.

@Tibor17
Copy link
Contributor

Tibor17 commented Jan 21, 2013

@gaffa
Download mvn snapshot
https://oss.sonatype.org/content/repositories/snapshots/junit/junit/4.12-SNAPSHOT

(link should be used only for uploads)

@gaffa
Copy link
Contributor Author

gaffa commented Jan 21, 2013

Thank you. Thats great. I am going to use that repository in one of our bigger projects to use the features. If I find any problems with anything I will submit issues.

@gaffa gaffa closed this as completed Jan 21, 2013
@gaffa gaffa reopened this Jan 21, 2013
@Tibor17
Copy link
Contributor

Tibor17 commented Jan 21, 2013

Pls do not download too frequently. Just cache it in your local repo and check from time to time what's new.

Submit issues, that's always helpful before making the release if somebody can check it out.

@gaffa
Copy link
Contributor Author

gaffa commented Jan 21, 2013

Alright. We can do that as well if you are worried about load or traffic. Good that you are saying it as I was not expecting that.

@gaffa gaffa closed this as completed Jan 24, 2013
@neoscaler
Copy link

Any news on the 4.12 release, it's now 11 month ago?! I would really appreciate the category inheritance.

@kcooney
Copy link
Member

kcooney commented Dec 24, 2013

I think we're just looking for someone to step up and do all the tasks related to the release.

@kcooney kcooney reopened this Dec 24, 2013
@pholser
Copy link
Contributor

pholser commented Jun 6, 2014

Anything I can do to help? I'd like to see 4.12 released so as to get on with a release of junit.contrib's rendition of Theories, which is a dependency of junit-quickcheck, which I'd also like to release sooner rather than later.

@kcooney
Copy link
Member

kcooney commented Jun 7, 2014

@pholser it would be really helpful for someone to organize the release notes for 4.12. Maybe add sections to the top for major features, minor features and bug fixes.

I wasn't involved in the 4.11 release, so I don't know what the other steps are. Perhaps someone in @junit-team/junit-committers can chime in.

@pholser
Copy link
Contributor

pholser commented Jun 8, 2014

@junit-team/junit-committers Sure, I can do that. Pull req for release note changes to follow, hopefully not too long.

@kcooney
Copy link
Member

kcooney commented Jun 8, 2014

@pholser the release notes are on the wiki, so you don't need a pull

@pholser
Copy link
Contributor

pholser commented Jun 8, 2014

Ah yes. Thanks!

@stefanbirkner
Copy link
Contributor

@pholser Do you want support for organizing the release notes. I could spend some time on it.

@pholser
Copy link
Contributor

pholser commented Jun 11, 2014

@stefanbirkner Sure -- was going to take a swing at it this evening; would you mind to have a look after I'm finished?

@pholser
Copy link
Contributor

pholser commented Jun 12, 2014

@junit-team/junit-committers I've edited the 4.12 release notes wiki entry. I took the approach of organizing the changes mentioned there by general JUnit feature category (e.g. rules, theories, assertions), taking a cue from another wiki page. Have a look and tweak as you see fit.

@kcooney
Copy link
Member

kcooney commented Jun 12, 2014

@pholser I like it.

Reviewing the release notes, I don't see any mention of Noel's work on inclusion and exclusion filters. I'm not sure if it's worth the time for someone to go through two years of commit history to see what else is missing :-/

@pholser
Copy link
Contributor

pholser commented Jun 12, 2014

@kcooney True, that. Perhaps someone more familiar with the changes would be willing to summarize them and update the notes? @stefanbirkner, would you be able to help with documenting the inclusion/exclusion filters, and any stray features/bug fixes that didn't make it to the release notes?

@pholser
Copy link
Contributor

pholser commented Jul 7, 2014

@kcooney @stefanbirkner @dsaff I think I've done about as much as I'm comfortable with re: the release notes for 4.12. Anything else that I could do to help the 4.12 release along?

@stefanbirkner
Copy link
Contributor

@pholser No it's our part to release 4.12. Thanks for your help.

@ceefour
Copy link

ceefour commented Jul 14, 2014

Yay :-) 👍

@pholser
Copy link
Contributor

pholser commented Jul 15, 2014

@stefanbirkner No worries, thanks. We're eager to see 4.12 in play soon.

@nhuray
Copy link

nhuray commented Jul 15, 2014

Great I'm waiting for this release for a long time. I'm particularly interested by Theories improvements !

@marcphilipp
Copy link
Member

There now is a public beta release (4.12-beta-1). Get it from Maven central or GitHub.

@kcooney
Copy link
Member

kcooney commented Nov 2, 2014

@marcphilipp should we do one more RC and then do the release? r4.12-beta-2 is missing #1000 (which is an incompatible change from r4.12-beta-2 but compatible with 4.12)

@marcphilipp marcphilipp added this to the 4.12 milestone Nov 3, 2014
@marcphilipp
Copy link
Member

Ok, one more RC... ;-)

@UrsMetz
Copy link
Contributor

UrsMetz commented Nov 3, 2014

Should the clarification for the JavaDoc of TemporaryFolder, cf. @kcooney's comment in #1001, be included in 4.12? Is somebody already taking care of this?

@kcooney
Copy link
Member

kcooney commented Nov 3, 2014

I personally would not want to wait for any pull requests that haven't been created. The only reason I am suggesting a new RC is to fix a compatibility issue with 4.11.

I would be happy not merging any more pull requests, and commit to do a bug fix release in 3 months.

@marcphilipp
Copy link
Member

I would be ok with fixing the Javadoc if a pull request is ready to be merged within the next few days. I won't have time to release beta-3 before the weekend anyway.

@UrsMetz Do you have time to take care of that?

@UrsMetz
Copy link
Contributor

UrsMetz commented Nov 4, 2014

@marcphilipp I think I could have a pull request ready by tomorrow or the day after tomorrow.

@marcphilipp
Copy link
Member

SGTM!

@kcooney
Copy link
Member

kcooney commented Nov 8, 2014

@marcphilipp sent you a pull for the (hopefully) final update to the release notes

@marcphilipp
Copy link
Member

I've added a few comments over at #1024.

@marcphilipp
Copy link
Member

4.12 is released. 🎆

@npathai
Copy link
Contributor

npathai commented Dec 5, 2014

Yayyy..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests