Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource leak in BaseTestRunner.java #729

Closed
jjarboe opened this issue Sep 1, 2013 · 0 comments
Closed

Resource leak in BaseTestRunner.java #729

jjarboe opened this issue Sep 1, 2013 · 0 comments

Comments

@jjarboe
Copy link

jjarboe commented Sep 1, 2013

Resource leak in src/main/java/junit/runner/BaseTestRunner.java

image

Note that you close "is" when an IOException is thrown, but not in the successful case. You might want to change that catch block to a finally block.
@dsaff dsaff closed this as completed in 9d9019e Sep 6, 2013
dsaff pushed a commit that referenced this issue Sep 6, 2013
Merge pull request #730 from stefanbirkner/issue-729
6047232 
Always close stream in readPreferences(). Fixes #729.
codingricky pushed a commit to codingricky/junit that referenced this issue Oct 6, 2013
@stefanbirkner
Always close stream in readPreferences(). Fixes junit-team#729.
5046380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jjarboe