Description builder #925
Merged
Description builder #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry methods to allow clients to specify alternative names for the Suites and Tests, without loosing the tied linking between the test result and the class / methods that specifies the test.
…ry methods to allow clients to specify alternative names for the Suites and Tests, without loosing the tied linking between the test result and the class / methods that specifies the test.
…into description-builder
|
Fantastic. I will add Description.toImmutableDescription() so we can use immutable descriptions in runners that implement Filterable |
|
When do you think this merged changed will be included in the next (un)official release? |
|
We were thinking this would be in the next major release after 4.12 (tentatively 5.0). I had some problems with this API when I was working on using it with the filtering code, so I don't think it is quite ready to be merged. |
|
@marcphilipp I was having some problems using the description builder in the filtering code. Hopefully I'll find time to give it another go in the next month |
|
@kcooney let me know, if I can support you with something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue of pull request #890:
As discussed in #890 I rebased the branch on immutable-description and created a new pull request.
All the best
bechte