Add overload of TestWatcher.skipped() that uses the external AssumptionViolationException

[kcooney]

Add overload of TestWatcher.skipped() that uses the external AssumptionViolationException

This allows code using TestWatcher to handle assumption violation exceptions
without using deprecated classes.

[dhasday]

With these updates, shouldn't there also be some tests that use the external version of AssumptionViolatedException to exercise the functionality? It looks like TestWatcherTest is only using the internal version.

[kcooney]

@dhasday Thanks for taking a look The methods on Assume throw the external version of AssumptionViolatedException

[dhasday]

@kcooney Sure, that makes sense, but these tests only verify backwards compatibility since all of the overridden skipped methods are using the internal version of AssumptionViolatedException. There doesn't seem to be any unit test coverage to verify an overridden skipped with the external version, specifically that it does not call skipped with the internal version too.

[kcooney]

@dhasday LoggingTestWatcher.skipped() uses the external version of AssumptionViolatedException. I don't expect people to write subclasses of TestWatcher where they override both versions of skipped() so I don't feel the need to test for test cases related to that.

If someone explicitly throws the internal AssumptionViolatedException in a test with a TestWatcher that only overrides the version of skipped() that uses the external AssumptionViolatedException then the skipped method won't be called (the external version extends the internal version). I didn't write a test for that, because I don't generally write tests to test that something didn't happen unless that something shouldn't happen. Is that the test case you mean?

[dhasday]

@kcooney I was specifically referring to the logic in skippedQuietly() that determines which version of skipped() to call since it's explicitly choosing between the internal and external versions.

As to LoggingTestWatcher, I was mistaken about that usage. Yes, it definitely covers the case where skipped() with the external version is used.

[stefanbirkner]

Could you move this class down after neitherLogSuccessNorFailedForViolatedAssumption The internal classes are always positioned above the test that is using them.

[kcooney]

@stefanbirkner Done and rebased and squashed commits.

[stefanbirkner]

Thanks.