Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FailOnTimeoutTest often fails on CloudBees #963

Closed
marcphilipp opened this issue Jul 27, 2014 · 4 comments
Closed

FailOnTimeoutTest often fails on CloudBees #963

marcphilipp opened this issue Jul 27, 2014 · 4 comments

Comments

@marcphilipp
Copy link
Member

... especially when executed within the Maven release build.

@kcooney
Copy link
Member

kcooney commented Jul 27, 2014

@marcphilipp thanks for the quick fix. Is there a page that shows the error message?

@marcphilipp
Copy link
Member Author

https://junit.ci.cloudbees.com/job/JUnit%20(Mavenized)/junit$junit/11/testReport/junit/junit.framework/JUnit4TestCaseFacade/throwsTestTimedOutException/

java.lang.AssertionError: Expected test to throw an instance of org.junit.runners.model.TestTimedOutException
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.rules.ExpectedException.failDueToMissingException(ExpectedException.java:263)
    at org.junit.rules.ExpectedException.access$200(ExpectedException.java:106)
    at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:245)
    at org.junit.rules.RunRules.evaluate(RunRules.java:20)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:55)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
    at org.junit.runners.Suite.runChild(Suite.java:128)
    at org.junit.runners.Suite.runChild(Suite.java:27)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
    at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:38)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:592)
    at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:95)
    at org.apache.maven.surefire.junit.JUnit3Provider.executeTestSet(JUnit3Provider.java:131)
    at org.apache.maven.surefire.junit.JUnit3Provider.invoke(JUnit3Provider.java:108)
    at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
    at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
    at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)

@marcphilipp
Copy link
Member Author

Looks like #962 would fix this issue.

@stefanbirkner Other ideas?

stefanbirkner added a commit to stefanbirkner/junit that referenced this issue Jul 28, 2014
The time between starting the statement and calling the future is
arbitrary. Now the execution time of the statement is very very long.
This ensures that the statement is not already finished when the
future is called.
@stefanbirkner
Copy link
Contributor

Please have a look at pull request #967.

marcphilipp added a commit that referenced this issue Jul 28, 2014
Increase running time of statement. Fixes #963.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants