Provide helpful message if parameter cannot be set. #1465
Conversation
| @@ -73,6 +73,10 @@ private Object createTestUsingFieldInjection() throws Exception { | |||
| int index = annotation.value(); | |||
| try { | |||
| field.set(testClassInstance, parameters[index]); | |||
| } catch (IllegalAccessException e) { | |||
| throw new Exception("Cannot set parameter '" + field.getName() | |||
There was a problem hiding this comment.
Are you sure we shouldn't set the cause of this exception?
Also, throwing ``Exceptionis rare. Perhaps we should throw a newIllegalAccessException`
There was a problem hiding this comment.
You're right with the cause. The problem with creating a new IllegalAccessException is that it doesn't have a constructor with a cause argument.
There was a problem hiding this comment.
You can use https://docs.oracle.com/javase/7/docs/api/java/lang/Throwable.html#initCause(java.lang.Throwable) to set the cause.on the IllegalAccessException. Can we do that?
There was a problem hiding this comment.
And again you're right. I fixed it and already squashed the commits.
stefanbirkner
force-pushed
the
private-parameters
branch
from
ba59698
to
46c6ea9
Compare
|
When I have your okay for the pull request I will squash the commits and merge to master. |
stefanbirkner
force-pushed
the
private-parameters
branch
from
46c6ea9
to
7e3a6b9
Compare
stefanbirkner
force-pushed
the
private-parameters
branch
2 times, most recently
from
ad3d20c
to
709a705
Compare
For private @parameter fields is users get an exception like "java.lang.IllegalAccessException: Class ... can not access a member of class X with modifiers private" The new message "Cannot set parameter 'parameter'. Ensure that the the field 'parameter' is public." tells the user what they should do. The reason for adding this feature is the Stackoverflow question https://stackoverflow.com/questions/44522046/reflection-exception-in-parameterized-junit-test-using-array-parameter/44522988
stefanbirkner
force-pushed
the
private-parameters
branch
from
709a705
to
6324fde
Compare
For private @parameter fields is users get an exception like "java.lang.IllegalAccessException: Class ... can not access a member of class X with modifiers private" The new message "Cannot set parameter 'parameter'. Ensure that the the field 'parameter' is public." tells the user what they should do.
The reason for adding this feature is the Stackoverflow question https://stackoverflow.com/questions/44522046/reflection-exception-in-parameterized-junit-test-using-array-parameter/44522988