Added MainRunner. This removes the need for public methods in JUnitCore #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MainRunner installs a SecurityManager which traps the System.exit(), thereby removing the need to have runMainAndExit and runMain public in JUnitCore. MainRunner is only used in the tests of course.
|
I like this, in general. Can you run some github searches, and post quickly on junit-users, to make sure there are no non-test users of these methods? |
|
Posted to junit group, the github search reveals two projects: https://github.com/SteMo/Zeiterfassung_HiWis_TUD (single use) |
dsaff
added a commit
that referenced
this pull request
Apr 3, 2012
Added MainRunner. This removes the need for public methods in JUnitCore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainRunner installs a SecurityManager which traps the System.exit(), thereby
removing the need to have runMainAndExit and runMain public in JUnitCore.
MainRunner is only used in the tests of course.
The idea of this change is to remove the public methods runMainAndExit and runMain.