Optimize memory consumption in junit.framework.Assert

[vbauer]

New class org.junit.Assert already contains optimized assert methods (with Long.valueOf etc), for example:

    static public void assertEquals(String message, long expected, long actual) {
        if (expected != actual) {
            failNotEquals(message, Long.valueOf(expected), Long.valueOf(actual));
        }
    }

Old (deprecated) version of this class (junit.framework.Assert) contains not-optimized methods, for example:

    static public void assertEquals(String message, long expected, long actual) {
        assertEquals(message, new Long(expected), new Long(actual));
    }

Whole class is deprecated, but I sure that this methods are still used in many projects, so I suggest to optimize them, until they are presented in JUnit.

[kcooney]

This actually isn't an optimization; Double.valueOf(double d) just calls 'new Double(d)'

Let's just remove this change. Since this class is deprecated, I want to minimize changes to it wherever possible.

[vbauer]

Absolutely agree, I've just repeat the same approach, that was used in new Assert class to work with Float and Double types. It is not a problem to revert it. :)

[kcooney]

Thanks for the contribution. I was almost tempted to close this without pulling it; part of the benefit of deprecating a class is that we can reduce the maintenance time by avoiding unnecessary changes to the class. But this looks really safe (famous last words :-)

[vbauer]

Yes, it should be safe. Will it be accepted if I revert changes with Float and Double types?

[kcooney]

I'd be happy to pull if you revert the changes with Float and Double

[vbauer]

Ok, some changes were reverted

[kcooney]

Thanks!

[vbauer]

Thank you for merge!