Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align gradle plugin and runner features with Launcher API #312

Closed
6 tasks done
sbrannen opened this issue Jun 18, 2016 · 2 comments
Closed
6 tasks done

Align gradle plugin and runner features with Launcher API #312

sbrannen opened this issue Jun 18, 2016 · 2 comments
Assignees
@sbrannen
Labels
theme: build theme: programming model type: enhancement
Milestone
5.0 M1

Comments

@sbrannen
Copy link
Member

sbrannen commented Jun 18, 2016 •
edited
Loading

Status Quo

The JUnitPlatformPlugin (Gradle plugin), JUnitPlatform (JUnit 4 Runner), and ConsoleRunner currently have slightly different APIs and feature sets than what is supported by the Launcher APIs.3

Goals

For consistency and future proofing of these APIs we therefore need to align all public APIs for end users.

Specifically, actions related to DiscoverySelectors must be named "select" something. Similarly, filters must be named "include" or "exclude" something.

Related Issues

Deliverables

  • Rename @Packages to @SelectPackages
  • Rename @Classes to @SelectClasses
  • Rename byClassNamePattern() in ClassFilter to includeClassNamePattern()
  • Rename @FilterClassName to @IncludeClassNamePattern
  • Rename matchClassName in Gradle plugin to includeClassNamePattern
  • Rename --filter-classname option in ConsoleRunner to --include-classname
@sbrannen sbrannen added this to the 5.0 M1 milestone Jun 18, 2016
@sbrannen sbrannen self-assigned this Jun 18, 2016
@sbrannen
Copy link
Member Author

in progress

sbrannen added a commit that referenced this issue Jun 18, 2016
@sbrannen
Rename @Packages to @SelectPackages
3e3e762 
Issue: #312
sbrannen added a commit that referenced this issue Jun 18, 2016
@sbrannen
Rename @classes to @SelectClasses
2a87be1 
Issue: #312
sbrannen added a commit that referenced this issue Jun 18, 2016
@sbrannen
Polish Javadoc for JUnitPlatform runner annotations
7cf3a5c 
Issue: #312
sbrannen added a commit that referenced this issue Jun 18, 2016
@sbrannen
Apply consistent naming for class name include patterns
8f23f4f 
- byClassNamePattern() in ClassFilter --> includeClassNamePattern()
- @FilterClassName --> @IncludeClassNamePattern
- matchClassName in Gradle plugin --> includeClassNamePattern
- --filter-classname option in ConsoleRunner --> --include-classname

Issue: #312
@sbrannen
Copy link
Member Author

sbrannen commented Jun 18, 2016 •
edited
Loading

All deliverables have been pushed to master.

This was referenced Jun 18, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
theme: build theme: programming model type: enhancement
Projects
None yet
Milestone
5.0 M1
Development

No branches or pull requests
1 participant
@sbrannen